Messages in this thread | | | Date | Tue, 13 Jul 2010 14:57:09 +0200 | From | Martin Jansa <> | Subject | Re: [PATCH] kbuild: setlocalversion should respect srctree param when looking for auto.conf |
| |
On Tue, Jul 13, 2010 at 02:36:51PM +0200, Michal Marek wrote: > On 07/13/2010 11:34 AM, Martin Jansa wrote: > > * it works properly only when CWD == scrtree > > * with this patch: > > jama src # /usr/src/linux/scripts/setlocalversion /usr/src/linux > > -JaMa-00001-g18672de > > * without: > > jama src # /usr/src/linux/scripts/setlocalversion /usr/src/linux > > Error: kernelrelease not valid - run 'make prepare' to update it > > This doesn't look correct, include/config/auto.conf is generated in the > build directory (*), where this script is called from by the Makefile. > If you call the script manually, you have to cd to the build directory > first. > > (*) which is different from the source directory if you build with O=.
Ah OK, I didn't notice that auto.conf should be generated in build directory (in my case build dir == source dir).
I just noticed broken kernel module builds in gentoo, because local version is also checked without changing CWD KV_LOCAL="${KV_LOCAL}$(sh ${KV_DIR}/scripts/setlocalversion ${KV_DIR})" in get_version() http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/linux-info.eclass?view=markup
So if scripts/* behavior is not considered as "API" then it should be fixed in gentoo eclass. It also appends LOCALVERSION twice now, because first appends LOCALVERSION from config and then calls setlocalversion also returning it at the beginning.
Thanks
Regards,
-- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
| |