Messages in this thread | | | Subject | Re: [PATCH net-next] drivers/scsi: Remove warnings after vsprintf %pV introduction | From | James Bottomley <> | Date | Mon, 12 Jul 2010 04:27:18 -0400 |
| |
On Sat, 2010-07-10 at 23:10 -0700, David Miller wrote: > From: Joe Perches <joe@perches.com> > Date: Sat, 10 Jul 2010 22:08:41 -0700 > > > On Sat, 2010-07-10 at 19:52 -0700, David Miller wrote: > >> Could you take a stab at this and the other scsi bits that > >> trigger this warning? > > > > Remove warnings introduced by conversions of dev_<level> > > macros to functions. > > > > Compile tested only. > > > > Signed-off-by: Joe Perches <joe@perches.com> > > SCSI folks, the background is that we have moved the dev_*() printk > macros to external functions, so that the prefixing printf strings > don't get emitting at every call site. > > As a consequence, dev_*() calls that try to use an empty string as the > printf format emit a warning from gcc since an empty constant string > is not a valid printf format. > > That's what this change is all about.
Thanks, that explains the "" -> " " conversions.
What's the other 60% of the patch about? the strange addition of scsi_show_extd_sense_args() and all the KERN_CONT bits?
James
| |