lkml.org 
[lkml]   [2010]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: tidspbridge: fix build error for missing variable
Menon, Nishanth had written, on 07/12/2010 05:56 PM, the following:
> Commit:
> staging: tidspbridge: gen: simplify and clean up
> There is recently added hex_to_bin() kernel's method which we could use
> instead of custom long function.
>
> Introduced usage of hex_to_bin without defining the temp variable.
> this causes the build error:
> drivers/staging/tidspbridge/gen/uuidutil.c: In function 'uuid_hex_to_bin':
> drivers/staging/tidspbridge/gen/uuidutil.c:63: error: 'value' undeclared (first use in this function)
> drivers/staging/tidspbridge/gen/uuidutil.c:63: error: (Each undeclared identifier is reported only once
> drivers/staging/tidspbridge/gen/uuidutil.c:63: error: for each function it appears in.)
>
> introduce variable value to fix the error.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> drivers/staging/tidspbridge/gen/uuidutil.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/tidspbridge/gen/uuidutil.c b/drivers/staging/tidspbridge/gen/uuidutil.c
> index eb09bc3..070761b 100644
> --- a/drivers/staging/tidspbridge/gen/uuidutil.c
> +++ b/drivers/staging/tidspbridge/gen/uuidutil.c
> @@ -58,6 +58,7 @@ static s32 uuid_hex_to_bin(char *buf, s32 len)
> {
> s32 i;
> s32 result = 0;
> + int value;
>
> for (i = 0; i < len; i++) {
> value = hex_to_bin(*buf++);
arrgh.. just saw https://patchwork.kernel.org/patch/111141/ - please
consider the same and drop this patch. apologies on the noise.

--
Regards,
Nishanth Menon


\
 
 \ /
  Last update: 2010-07-13 01:17    [W:0.027 / U:1.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site