lkml.org 
[lkml]   [2010]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectPossible false positive from checkpatch.pl
    Andy,

    In preparing a vendor driver for submission to staging, I am getting the
    following from checkpatch.pl:

    ERROR: Macros with multiple statements should be enclosed in a do - while loop
    #377: FILE: staging/rtl8712/rtl871x_mp_ioctl.h:377:
    +#define GEN_MP_IOCTL_HANDLER(sz, hdl, oid) {sz, hdl, oid},

    ERROR: Macros with multiple statements should be enclosed in a do - while loop
    #378: FILE: staging/rtl8712/rtl871x_mp_ioctl.h:378:
    +#define EXT_MP_IOCTL_HANDLER(sz, subcode, oid) {sz, &mp_ioctl_ \
    + ## subcode ## _hdl, oid},

    total: 2 errors, 0 warnings, 466 lines checked

    Enclosing these macros in a do {...} while (0) is definitely wrong and will not
    compile. Moving the comma from the end of the macro to the lines that invoke it
    fixes the problem, but should not be necessary.

    Thanks,



    \
     
     \ /
      Last update: 2010-07-12 19:55    [W:3.245 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site