Messages in this thread | | | Date | Sat, 10 Jul 2010 19:52:10 -0700 (PDT) | Subject | Re: linux-next: build warning after merge of the net tree | From | David Miller <> |
| |
From: Joe Perches <joe@perches.com> Date: Wed, 07 Jul 2010 21:13:42 -0700
> On Wed, 2010-07-07 at 18:18 -0700, David Miller wrote: >> It looks like there are just a hand-ful of cases, so maybe we can tweak >> them by hand. For example, in the sym53c8xx_2 driver bits we can replace >> the NULL labels passed to sym_print_msg() with a real string and therefore >> remove the "" case. >> >> Joe, any better ideas? > > You're right there are just a few cases where dev_info > is uses as a preface for a hex_dump style display. > > Maybe it'd be OK to simply add a trailing space to the > preface and remove any leading spaces from the subsequent > initial printks. > > dev_info(dev, " ");
That might work.
The sym53c8xx_2 doesn't even need this, like I said, you could just remove the NULL 'label' argument cases and then have that bit cured.
Could you take a stab at this and the other scsi bits that trigger this warning?
Thanks Joe!
| |