Messages in this thread | | | Date | Thu, 01 Jul 2010 14:31:02 -0700 | From | "Justin P. Mattock" <> | Subject | Re: [PATCH]kernel.h Move warning message about using kernel headers for userspace to types.h |
| |
On 07/01/2010 01:38 PM, Arnd Bergmann wrote: > On Thursday 01 July 2010, Justin P. Mattock wrote: >> o.k. I resent an updated version. keep in mind this is a bit confusing >> with the __KERNEL__ being in there multiple times, but with the v2 I'm >> able to see the #warning message with my little program. > > Well, it's technically correct, but the #ifndef __KERNEL__ in there > would better get dropped, since you are already in the #else path. >
ahh.. I see now(makes sense). I resent this with the above change.
>> As for the patch itself hopefully I corrected it's changelog etc.. >> lately I've been a bit confused with the whole sighned off thing i.g. >> you suggested the #else so naturally I should add your name with a >> sighned off, but with other patches I was told not to do so due to the >> sighned off procedure/process. I'll re-read the submitting patches again >> to make sure. > > You got that part right. The S-o-b only ever gets added by a person > sending a patch for the sending address, so you would not add my > address as S-o-B, though you could add it as Cc:. > When someone picks up your patch and forwards it, that person > will add his/her own S-o-b line below yours and keep you listed > as From. > > Arnd >
o.k. I added a Cc, then down the line the sob's are added etc.
Justin P. Mattock
| |