lkml.org 
[lkml]   [2010]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH]kernel.h Move warning message about using kernel headers for userspace to types.h
Date
On Thursday 01 July 2010, Justin P. Mattock wrote:
> o.k. I resent an updated version. keep in mind this is a bit confusing
> with the __KERNEL__ being in there multiple times, but with the v2 I'm
> able to see the #warning message with my little program.

Well, it's technically correct, but the #ifndef __KERNEL__ in there
would better get dropped, since you are already in the #else path.

> As for the patch itself hopefully I corrected it's changelog etc..
> lately I've been a bit confused with the whole sighned off thing i.g.
> you suggested the #else so naturally I should add your name with a
> sighned off, but with other patches I was told not to do so due to the
> sighned off procedure/process. I'll re-read the submitting patches again
> to make sure.

You got that part right. The S-o-b only ever gets added by a person
sending a patch for the sending address, so you would not add my
address as S-o-B, though you could add it as Cc:.
When someone picks up your patch and forwards it, that person
will add his/her own S-o-b line below yours and keep you listed
as From.

Arnd


\
 
 \ /
  Last update: 2010-07-01 22:41    [W:0.075 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site