Messages in this thread | | | Date | Thu, 1 Jul 2010 10:09:39 -0400 (EDT) | From | Alan Stern <> | Subject | Re: [PATCH] USB: gadget: mass storage: use proper device class in device desc |
| |
On Thu, 1 Jul 2010, Michal Nazarewicz wrote:
> Hello Alan, > > Each time I see the device descriptor of the File Storage Gadget > I wonder if it shouldn't be set to the real value rather then leaving > it as per interface.
It should not be changed.
> Is there a reason to leave it as per interface?
See Table 4.1 in the USB Mass Storage Bulk-Only Transport specification and Table 3.1 in the CBI Transport specification.
> Will chenging it to > the real value change anything?
You mean will it hurt anything? I don't know; I have never tried it.
> I checked my pendrive and an IDE<->USB adapter they as well use a per > interface class but maybe it'll be better to use proper call any way?
No. And it's not a proper call -- it's not even the proper descriptor valu. So NAK on this patch.
Alan Stern
| |