lkml.org 
[lkml]   [2010]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] OMAP:DSS2:OMAPFB: Fix probe error path
    Date
    Move sysfs entry creation to omapfb_probe() from omapfb_create_framebuffers().
    This will make sure that sysfs entry is not left behind in case of unsuccessful
    probe due to failure in enabling fb0 of omapfb_create_framebuffers().

    Signed-off-by: Afzal Mohammed <lazfamam@gmail.com>
    ---
    drivers/video/omap2/omapfb/omapfb-main.c | 14 +++++++-------
    1 files changed, 7 insertions(+), 7 deletions(-)

    diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c
    index 4b4506d..710e117 100644
    --- a/drivers/video/omap2/omapfb/omapfb-main.c
    +++ b/drivers/video/omap2/omapfb/omapfb-main.c
    @@ -1928,13 +1928,6 @@ static int omapfb_create_framebuffers(struct omapfb2_device *fbdev)
    }
    }

    - DBG("create sysfs for fbs\n");
    - r = omapfb_create_sysfs(fbdev);
    - if (r) {
    - dev_err(fbdev->dev, "failed to create sysfs entries\n");
    - return r;
    - }
    -
    /* Enable fb0 */
    if (fbdev->num_fbs > 0) {
    struct omapfb_info *ofbi = FB2OFB(fbdev->fbs[0]);
    @@ -2220,6 +2213,13 @@ static int omapfb_probe(struct platform_device *pdev)
    }
    }

    + DBG("create sysfs for fbs\n");
    + r = omapfb_create_sysfs(fbdev);
    + if (r) {
    + dev_err(fbdev->dev, "failed to create sysfs entries\n");
    + goto cleanup;
    + }
    +
    return 0;

    cleanup:
    --
    1.7.0.4


    \
     
     \ /
      Last update: 2010-07-01 15:43    [W:0.042 / U:1.968 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site