[lkml]   [2010]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] Fix a race in pid generation that causes pids to be reused immediately.

    On Wed, 9 Jun 2010, Salman Qazi wrote:
    > I don't think this gives the right answer in the a < base < b case.
    > Here a - base < 0 and
    > b - base > 0. But we really want b to be before a, since a has rolled
    > over further than b.

    Right you are.

    > I think the right solution is comparing (a - base + max_pid) % max_pid
    > with (b - base + max_pid) % max_pid. Am I correct or deluded? .

    That would work, but it would be horrible. Just use the three compares
    version: doing a integer 'mod' operator is _way_ more expensive.


     \ /
      Last update: 2010-06-10 02:23    [W:0.020 / U:22.380 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site