lkml.org 
[lkml]   [2010]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Fix a race in pid generation that causes pids to be reused immediately.


    On Wed, 9 Jun 2010, Linus Torvalds wrote:
    >
    > Quite possibly. I'd worry about the overflow case a bit, but it's
    > certainly going to get the right value when base << MAX_INT.

    Having given it a couple of seconds more thought, I don't think there is
    an overflow case either. All of a/b/base are guaranteed to be non-negative
    (or our pid code is in worse trouble anyway), so there is no overflow
    possible. So yes. Just comparing a-base < b-base should always be safe.

    Linus




    \
     
     \ /
      Last update: 2010-06-10 00:31    [W:0.021 / U:120.624 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site