Messages in this thread | | | From | "Xin, Xiaohui" <> | Date | Wed, 9 Jun 2010 15:34:16 +0800 | Subject | RE: [RFC PATCH v7 08/19] Make __alloc_skb() to get external buffer. |
| |
>-----Original Message----- >From: Eric Dumazet [mailto:eric.dumazet@gmail.com] >Sent: Saturday, June 05, 2010 10:53 PM >To: Xin, Xiaohui >Cc: netdev@vger.kernel.org; kvm@vger.kernel.org; linux-kernel@vger.kernel.org; >mst@redhat.com; mingo@elte.hu; davem@davemloft.net; herbert@gondor.apana.org.au; >jdike@linux.intel.com >Subject: Re: [RFC PATCH v7 08/19] Make __alloc_skb() to get external buffer. > >Le samedi 05 juin 2010 à 18:14 +0800, xiaohui.xin@intel.com a écrit : >> From: Xin Xiaohui <xiaohui.xin@intel.com> >> child->fclone = SKB_FCLONE_UNAVAILABLE; >> } >> + /* Record the external buffer info in this field. It's not so good, >> + * but we cannot find another place easily. >> + */ >> + shinfo->destructor_arg = ext_page; >> + > > >Yes this is a big problem, its basically using a cache line that was not >touched before. >
Did your patch which moves destructor_arg before frags[] also fix this?
Thanks Xiaohui -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |