Messages in this thread | | | Date | Tue, 8 Jun 2010 16:32:12 +0900 | From | Paul Mundt <> | Subject | Re: [PATCH, v2] kbuild: Improve version string logic - two for the price of one - No thanks |
| |
On Tue, Jun 08, 2010 at 10:21:54AM +0300, Boaz Harrosh wrote: > On 06/08/2010 10:16 AM, Boaz Harrosh wrote: > OK I get it above should be: > [my-tree] $ echo "-my_tree" > localversion-my_tree > > But now I get DEPMOD 2.6.35-rc2-my_tree+ > > Please fix it so if localversion* is present then the plus is > removed. And the git is not inspected > How is that a 'fix'? If I'm using localversion* and have people sending me bug reports, I still do want to see the git ID. The + thing in this context might not have any meaning since the 2.6.35-rc2 that you've tagged for your tree and the release one could wildly differ, but that's more of an argument against the + thing existing at all than anything else.
Whether having LOCALVERSION_AUTO be compulsory is a good idea or not is another matter entirely, the localversion* semantics are pretty clear-cut.
| |