lkml.org 
[lkml]   [2010]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [git pull] drm fixes


On Wed, 9 Jun 2010, Dave Airlie wrote:
>
> So this pull does try and fix some problems in a feature we added in -rc1,
> radeon power management, its either the voltage fixes in here, or just
> remove voltage stuff completely, but since it works in some cases that
> would be a regression in itself.

I'm going to take this and hope _really_ hard that it works - since the
number of current radeon reports seems to mean that I pretty much have to
take it.

But I want to protest that "regression in itself" statement. We do _not_
count new code that needs to be undone as a "regression". Otherwise we
would be in the situation where "fix one bug, introduce another" could not
be reverted, because reverting it would "regress" the bug that got fixed.

And in fact that's exactly _why_ we introduced the strict regression
fixing policy, because we used to have these "one step forward, unknown
number of steps back" dances especially in power management and ACPI. A
patch fixed something, but broke some other machine, and people claimed it
fixed more than it broke (which is an impossible statement to really
quantify).

So new code simply doesn't matter. Reverting new code is never a
regression, even if that new code made something work. It's _old_ working
setups that matter from the regression standpoint.

Linus


\
 
 \ /
  Last update: 2010-06-09 05:19    [W:0.030 / U:8.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site