lkml.org 
[lkml]   [2010]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: cpqphp: NULL ptr deref in cpqhpc_probe
On Tue, Jun 08, 2010 at 02:37:39PM -0700, Jesse Barnes wrote:
> On Thu, 03 Jun 2010 11:24:22 +0200
> Jiri Slaby <jslaby@suse.cz> wrote:
>
> > Hi,
> >
> > we have a system where there is a pci hotplug class device to be handled
> > by cpqphp, but it is not a bridge. But in cpqhpc_probe there is:
> > struct pci_bus *bus;
> > ...
> > bus = pdev->subordinate;
> > ...
> > bus->max_bus_speed = PCI_SPEED_66MHz_PCIX;
> >
> > But as it is not a bridge, subordinate is NULL and the kernel crashes.
> >
> > Any idea what would be a correct fix here?
> >
> > The bugzilla entry is at:
> > https://bugzilla.novell.com/show_bug.cgi?id=609338
>
> I don't think we have anyone actively working on CPQHPC these days.
> Seems like the simple patch would be to check whether pdev->subordinate
> or bus exists before using it... Have you poked around for specs on
> this at all?

I don't think I even have the specs anymore. I ported the code from 2.4
back in 2001 or so and got it merged. I didn't think this device was
still even around in systems.

a simple check would be best.

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-06-09 01:17    [W:0.092 / U:43.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site