lkml.org 
[lkml]   [2010]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 00/17] MAINTAINERS: Add drivers/staging entries
From
Date
On Tue, 2010-06-08 at 14:12 -0700, Greg KH wrote:
> On Mon, Jun 07, 2010 at 11:49:34AM -0700, Joe Perches wrote:
> > Some drivers/staging directories use a TODO file with email entries.
> > Make the same entries in the normal MAINTAINERS file.
>
> No, please don't do this. I don't want to clutter up the MAINTAINERS
> file with staging stuff.

It's not clutter when it helps get patches to the right reviewers
or responsible parties.

> The get_maintainer.pl script handles staging
> patches just fine today without this being needed at all.

Dubious.

Many of these nominal maintainer email entries are not
found in git logs.

For instance:

$ grep "@" drivers/staging/dt3155/TODO
Please send patches to Greg Kroah-Hartman <greg@kroah.com>
and Scott Smedley <ss@aao.gov.au>

$ ./scripts/get_maintainer.pl -f drivers/staging/dt3155/
Greg Kroah-Hartman <gregkh@suse.de>
Simon Horman <horms@verge.net.au>
H Hartley Sweeten <hsweeten@visionengravers.com>
devel@driverdev.osuosl.org
linux-kernel@vger.kernel.org

Some have cc:'d entries, but not many actually have
Signed-off-by's. Perhaps that's because the individuals
are not frequently cc'd on the actual patches. Perhaps
because the people that put their names in the TODO's
just don't care.

> I also found it a bit odd you didn't send these to the stable subsystem
> maintainer, why?

The MAINTAINERS patches are forward going, not historical.

cheers, Joe



\
 
 \ /
  Last update: 2010-06-08 23:29    [W:0.039 / U:0.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site