Messages in this thread | | | Date | Tue, 8 Jun 2010 13:41:23 -0700 | From | jacob pan <> | Subject | Re: [PATCH] x86/sfi: fix ioapic gsi range |
| |
On Tue, 08 Jun 2010 12:41:45 -0700 ebiederm@xmission.com (Eric W. Biederman) wrote:
> Even if sfi is never implemented on a platform where that kind of > hardware exists, the current sfi code is setup to coexist > simultaneously in the kernel with all of the infrastructure of other > platforms where those kinds of devices exist. Which means there can > be drivers compiled into your kernel that make assumptions about > special properties of the irqs 0-15. > SFI code can be compiled in with ACPI at the same time but at runtime there is only one used, ACPI take precedence. So there wouldn't be any additional conflict caused by SFI added APIC tables.
> As for the question about using legacy_pic to detect the absence of > an irq controller that Peter raised. We can't do that because it > should be possible for an acpi system with all of the legacy hardware > to exist without needing to implement an i8259, or ever run in the > historical interrupt delivery mode of pcs. In your case, I don't understand how would it change the calculation of irq mapping. Even if you don't use i8259 on a x86 PC platform, you still have NR_LEGACY_IRQS=legacy_pic->nr_legacy_irqs.
On the other side, use NR_LEGACY_IRQS breaks the existing code for Moorestown in terms of irq-gsi lookup and nr_irqs_gsi.
| |