[lkml]   [2010]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [git pull] drm fixes
On Mon, 2010-06-07 at 14:17 -0700, Linus Torvalds wrote:
> and that changelog doesn't really explain it either ("fix leak"? Ok, I can
> see the iput() fixing the leak - but you also did that jffs2_clear_inode()
> change, and that has no explanation what-so-ever.

jffs2_clear_inode() is the file system's ->clear_inode method, so it
gets called from the VFS when the inode is destroyed, after iput().

I suppose that ought to have been a clue, right from the very beginning,
that we should never have been calling it directly on our error paths.

David Woodhouse Open Source Technology Centre Intel Corporation

 \ /
  Last update: 2010-06-07 23:43    [W:0.056 / U:4.840 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site