lkml.org 
[lkml]   [2010]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [BUG][PATCH]dma-coherent.c: error path bug
Date
On Monday, June 07, 2010 05:30:48 am FUJITA Tomonori wrote:
> On Sun, 6 Jun 2010 13:53:04 +0300
> Marin Mitov <mitov@issp.bas.bg> wrote:
>
> > Hi all,
> >
> > The error path in dma_declare_coherent_memory() leaves
> > the pointer dev->dma_mem non completely initialized.
> >
> > If allocation of dev->dma_mem succeeds,
> > but allocation of dev->dma_mem->bitmap fails
> > dev->dma_mem is freed, but left non NULL
> > and non completely initialized.
> >
> > Either zero it after being freed (one liner patch), or assign to
> > dev->dma_mem only completely initialized structure (patch included).
> >
> > Comments welcome.
> >
> > Marin Mitov
> >
> > Signed-off-by: Marin Mitov <mitov@issp.bas.bg>
>
> Hmm, if dma_declare_coherent_memory() fails, the driver doesn't use
> dev->dma_mem. So even if dev->dma_mem points to a freed memory, I'm
> not sure that it causes a real problem. We could call this patch a
> cleanup though.
>
My understanding of dma_alloc_coherent() is that we first try to allocate from
per-device coherent memory and we do it using dma_alloc_from_coherent()
(in drivers/base/dma-coherent.c) if dev->dma_mem is not NULL (and we have
left it not NULL, here is the problem). If allocation of dev->dma_mem->bitmap
fails dev->dma_mem must be NULL.

Marin Mitov



\
 
 \ /
  Last update: 2010-06-07 06:15    [W:0.208 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site