lkml.org 
[lkml]   [2010]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6] regulator: new drivers for AD5398 and AD5821
On Fri, Jun 04, 2010 at 12:40:46PM +0800, sonic zhang wrote:

> The AD5398 and AD5821 are single 10-bit DAC with 120 mA output current
> sink capability. They feature an internal reference and operates from
> a single 2.7 V to 5.5 V supply.

> This driver supports both the AD5398 and the AD5821. It adapts into the
> voltage and current framework.

> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

but

> +static int __init ad5398_init(void)
> +{
> + return i2c_add_driver(&ad5398_driver);
> +}
> +module_init(ad5398_init);

at least some systems are likely to want this to be subsys_initcall() to
make sure the regulator is available prior to the consumers. Please
send an incremental change for this rather than repostnig the full
thing.


\
 
 \ /
  Last update: 2010-06-07 14:31    [W:0.052 / U:1.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site