lkml.org 
[lkml]   [2010]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCHv5 14/16] HFS: kill hfs_buffer_sync
    Date
    From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

    and use 'sync_dirty_buffer()' instead, which is the right way
    of doing synchronization.

    Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
    ---
    fs/hfs/hfs_fs.h | 11 -----------
    fs/hfs/mdb.c | 4 ++--
    2 files changed, 2 insertions(+), 13 deletions(-)

    diff --git a/fs/hfs/hfs_fs.h b/fs/hfs/hfs_fs.h
    index 99b5866..3514e7a 100644
    --- a/fs/hfs/hfs_fs.h
    +++ b/fs/hfs/hfs_fs.h
    @@ -254,17 +254,6 @@ static inline void hfs_bitmap_dirty(struct super_block *sb)
    sb_mark_dirty(sb);
    }

    -static inline void hfs_buffer_sync(struct buffer_head *bh)
    -{
    - while (buffer_locked(bh)) {
    - wait_on_buffer(bh);
    - }
    - if (buffer_dirty(bh)) {
    - ll_rw_block(WRITE, 1, &bh);
    - wait_on_buffer(bh);
    - }
    -}
    -
    #define sb_bread512(sb, sec, data) ({ \
    struct buffer_head *__bh; \
    sector_t __block; \
    diff --git a/fs/hfs/mdb.c b/fs/hfs/mdb.c
    index 957945e..159ab88 100644
    --- a/fs/hfs/mdb.c
    +++ b/fs/hfs/mdb.c
    @@ -220,7 +220,7 @@ int hfs_mdb_get(struct super_block *sb)
    mdb->drLsMod = hfs_mtime();

    mark_buffer_dirty(HFS_SB(sb)->mdb_bh);
    - hfs_buffer_sync(HFS_SB(sb)->mdb_bh);
    + sync_dirty_buffer(HFS_SB(sb)->mdb_bh);
    }

    return 0;
    @@ -288,7 +288,7 @@ void hfs_mdb_commit(struct super_block *sb)
    HFS_SB(sb)->alt_mdb->drAtrb |= cpu_to_be16(HFS_SB_ATTRIB_UNMNT);
    HFS_SB(sb)->alt_mdb->drAtrb &= cpu_to_be16(~HFS_SB_ATTRIB_INCNSTNT);
    mark_buffer_dirty(HFS_SB(sb)->alt_mdb_bh);
    - hfs_buffer_sync(HFS_SB(sb)->alt_mdb_bh);
    + sync_dirty_buffer(HFS_SB(sb)->alt_mdb_bh);
    }

    if (test_and_clear_bit(HFS_FLG_BITMAP_DIRTY, &HFS_SB(sb)->flags)) {
    --
    1.7.0.1


    \
     
     \ /
      Last update: 2010-06-06 16:57    [W:0.043 / U:391.428 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site