lkml.org 
[lkml]   [2010]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCHv5 04/16] VFS: add memory barrier to sb_mark_clean and sb_mark_dirty
    From
    Date
    On Sun, 2010-06-06 at 17:50 +0300, Artem Bityutskiy wrote:
    > void sb_mark_dirty(struct super_block *sb);
    > static inline void sb_mark_clean(struct super_block *sb)
    > {
    > sb->s_dirty = 0;
    > + /*
    > + * Normally FSes first unset the sb->s_dirty flag, and then start
    > + * synchronizing the SB. The memory barrier ensures this order.
    > + */
    > + smp_mb();
    ...
    > void sb_mark_dirty(struct super_block *sb)
    > {
    > + /*
    > + * Normally FSes modify the SB, and then mark it as dirty. The memory
    > + * barrier ensures this order.
    > + */
    > + smp_mb();
    ...

    Hmm, these ones should be 'mb()', not 'smp_mb()'.

    --
    Best Regards,
    Artem Bityutskiy (Артём Битюцкий)

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-06-06 19:19    [W:0.021 / U:0.764 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site