Messages in this thread Patch in this message | | | Date | Fri, 4 Jun 2010 13:15:35 -0700 | From | Chris Wright <> | Subject | [PATCH] blkdev: cgroup whitelist permission fix |
| |
The cgroup device whitelist code gets confused when trying to grant permission to a disk partition that is not currently open. Part of blkdev_open() includes __blkdev_get() on the whole disk. This simply avoids the cgroup check for the whole disk case when opening a partition.
https://bugzilla.redhat.com/show_bug.cgi?id=589662
Acked-by: Serge E. Hallyn <serue@us.ibm.com> Tested-by: Serge E. Hallyn <serue@us.ibm.com> Signed-off-by: Chris Wright <chrisw@sous-sol.org> --- fs/block_dev.c | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/fs/block_dev.c b/fs/block_dev.c index 7346c96..09b107e 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -1315,10 +1315,12 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, int for_part) /* * hooks: /n/, see "layering violations". */ - ret = devcgroup_inode_permission(bdev->bd_inode, perm); - if (ret != 0) { - bdput(bdev); - return ret; + if (!for_part) { + ret = devcgroup_inode_permission(bdev->bd_inode, perm); + if (ret != 0) { + bdput(bdev); + return ret; + } } lock_kernel();
| |