Messages in this thread | | | Date | Fri, 04 Jun 2010 13:44:59 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH v4] block: avoid unconditionally freeing previously allocated request_queue |
| |
On 2010-06-03 19:34, Mike Snitzer wrote: > block: avoid unconditionally freeing previously allocated request_queue > > On blk_init_allocated_queue_node failure, only free the request_queue if > it is wasn't previously allocated outside the block layer > (e.g. blk_init_queue_node was blk_init_allocated_queue_node caller). > > This addresses an interface bug introduced by the following commit: > 01effb0 block: allow initialization of previously allocated > request_queue > > Otherwise the request_queue may be free'd out from underneath a caller > that is managing the request_queue directly (e.g. caller uses > blk_alloc_queue + blk_init_allocated_queue_node).
Thanks Mike, this looks a lot better. I have applied this one and 2/2 of the original posting.
-- Jens Axboe
| |