lkml.org 
[lkml]   [2010]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] KEYS: Reinstate lost passing of process keyring ID in call_sbin_request_key()
On Wed, 30 Jun 2010, David Howells wrote:

> From: Justin P. Mattock <justinmattock@gmail.com>
>
> In commit bb952bb98a7e479262c7eb25d5592545a3af147d there was the accidental
> deletion of a statement from call_sbin_request_key() to render the process
> keyring ID to a text string so that it can be passed to /sbin/request-key.
>
> With gcc 4.6.0 this causes the following warning:
>
> CC security/keys/request_key.o
> security/keys/request_key.c: In function 'call_sbin_request_key':
> security/keys/request_key.c:102:15: warning: variable 'prkey' set but not used
>
> This patch reinstates that statement.
>
> Without this statement, /sbin/request-key will get some random rubbish from the
> stack as that parameter.
>
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
> Signed-off-by: David Howells <dhowells@redhat.com>

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next


--
James Morris
<jmorris@namei.org>


\
 
 \ /
  Last update: 2010-07-01 02:23    [W:0.025 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site