| From | KOSAKI Motohiro <> | Subject | [PATCH 06/12] oom: remove warning for in mm-less task __oom_kill_process() | Date | Thu, 3 Jun 2010 15:23:03 +0900 (JST) |
| |
If the race of mm detach in task exiting vs oom is happen, find_lock_task_mm() can be return NULL.
So, the warning is pointless.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> --- mm/oom_kill.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 618cf44..d4484c5 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -402,12 +402,8 @@ static int __oom_kill_process(struct task_struct *p, struct mem_cgroup *mem, return 1; p = find_lock_task_mm(p); - if (!p) { - WARN_ON(1); - printk(KERN_WARNING "tried to kill an mm-less task %d (%s)!\n", - task_pid_nr(p), p->comm); + if (!p) return 1; - } if (verbose) printk(KERN_ERR "Killed process %d (%s) " -- 1.6.5.2
|