Messages in this thread | | | Date | Thu, 3 Jun 2010 11:11:25 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] hugetlb: call mmu notifiers on hugepage cow |
| |
On Thu, 3 Jun 2010 10:36:00 -0700 Doug Doan <dougd@cray.com> wrote:
> > Well, specifically it means that > > mmu_notifier_invalidate_range_start/end() implemetnations can no longer > > take page_table_lock or any lock which nests outside page_table_lock. > > That lessens flexibility. > > > > As the other mmu_notifier_invalidate_range_start/end() callsite in this > > function carefully nested those calls outside page_table_lock, perhaps > > that was thought to be a significant thing. > > Here's my rationale: for the normal page case, the invalidation call is done > inside a page_table_lock,
It is? Where does that happen?
> so the same should also be done in the huge page case. > Does it really make sense to call invalidation on one hugepage and have another > call invalidate the same hugepage while the first call is still not finished?
| |