Messages in this thread | | | Date | Thu, 3 Jun 2010 13:45:44 +0100 | From | Al Viro <> | Subject | Re: [patch] fcntl: return -EFAULT if copy_to_user fails |
| |
On Thu, Jun 03, 2010 at 07:22:34PM +0900, Takuya Yoshikawa wrote: > (2010/06/03 19:04), Dan Carpenter wrote: > >copy_to_user() returns the number of bytes remaining, but we want to > >return -EFAULT. > > > > ret = fcntl(fd, F_SETOWN_EX, NULL); > > > >With the original code ret would be 8 here. > > > >Signed-off-by: Dan Carpenter<error27@gmail.com> > > How about f_getown_ex() ? > > if (!ret) > ret = copy_to_user(owner_p, &owner, sizeof(owner)); > return ret; > > Fixing this too would be better, I think. > > Takuya
Applied, will push today.
| |