Messages in this thread | | | From | Bjorn Helgaas <> | Subject | Re: [PATCH 10/25] x86, lmb: Add lmb_to_bootmem() | Date | Tue, 29 Jun 2010 11:47:26 -0600 |
| |
On Tuesday, June 22, 2010 11:26:39 am Yinghai Lu wrote: > + pr_info("(%d early reservations) ==> bootmem [%010llx - %010llx]\n", count, start, end);
Please make all these address range messages match the %pR format.
> + for_each_lmb(reserved, r) { > + pr_info(" [%010llx - %010llx] ", (u64)r->base, (u64)r->base + r->size); > + final_start = max(start, r->base); > + final_end = min(end, r->base + r->size); > + if (final_start >= final_end) { > + pr_cont("\n"); > + continue; > + } > + pr_cont(" ==> [%010llx - %010llx]\n", final_start, final_end); > + reserve_bootmem_generic(final_start, final_end - final_start, BOOTMEM_DEFAULT); > + } > + > + /* Put region array back ? */ > + if (lmb.reserved.regions != lmb_reserved_init_regions) > + lmb_reserve(__pa(lmb.reserved.regions), sizeof(struct lmb_region) * lmb.reserved.max); > +} > +#endif >
| |