Messages in this thread | | | Subject | Re: [PATCH] arch/x86/kernel/cpu/mtrr/cleanup.c: Use ";" not "," to terminate statements | From | Joe Perches <> | Date | Mon, 28 Jun 2010 17:22:42 -0700 |
| |
On Tue, 2010-06-29 at 02:14 +0200, Ingo Molnar wrote: > That file and this subsystem needs a lot more cleanups than just this. Would > you be willing to do them all, so that we can get over with the churn in a > single well-defined patch (or patches)? > > I dont see much point in piecemail single-comma patches - i'd rather wait for > someone else who'd fix this and other details in one go.
I don't see significant style issues in mtrr
$ git ls-files arch/x86/kernel/cpu/mtrr/ | \ xargs ./scripts/checkpatch.pl -f
What do you think needs improving?git ls-files arch/x86/kernel/cpu/mtrr/ | \ xargs ./scripts/checkpatch.pl -f
| |