lkml.org 
[lkml]   [2010]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ASoC: DaVinci: Added support for cpu clocking I2S
    Raffaele Recalcati wrote:
    > + if (dev->i2s_fast_clock) {
    > + clk_div = 256;
    can you have
    f = (freq / params->rate_num) * params->rate_den;
    > + do {
    > + framesize = (freq / (--clk_div)) /
    > + params->rate_num *
    > + params->rate_den;
    and
    framesize = f / (--clk_div);
    > + } while (((framesize < 33) || (framesize > 4095)) &&
    > + (clk_div));
    > + clk_div--;
    looks like clk_div can go negative here, should the above while say (clk_div > 1)
    > + srgr |= DAVINCI_MCBSP_SRGR_FPER(framesize - 1);
    > + } else {
    > + /* symmetric waveforms */
    > + clk_div = freq / (mcbsp_word_length * 16) /
    > + params->rate_num * params->rate_den;
    > + srgr |= DAVINCI_MCBSP_SRGR_FPER(mcbsp_word_length *
    > + 16 - 1);
    > + }
    > + clk_div &= 0xFF;
    > + srgr |= clk_div;


    \
     
     \ /
      Last update: 2010-06-28 21:13    [W:0.022 / U:0.332 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site