lkml.org 
[lkml]   [2010]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Bluetooth: Fix abuse of the preincrement operator
    On 06/28/2010 05:57 AM, David Howells wrote:
    > Fix abuse of the preincrement operator as detected when building with gcc
    > 4.6.0:
    >
    > CC [M] drivers/bluetooth/hci_bcsp.o
    > drivers/bluetooth/hci_bcsp.c: In function 'bcsp_prepare_pkt':
    > drivers/bluetooth/hci_bcsp.c:247:20: warning: operation on 'bcsp->msgq_txseq' may be undefined
    >
    > Reported-by: Justin P. Mattock<justinmattock@gmail.com>
    > Signed-off-by: David Howells<dhowells@redhat.com>
    > ---
    >
    > drivers/bluetooth/hci_bcsp.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/bluetooth/hci_bcsp.c b/drivers/bluetooth/hci_bcsp.c
    > index 40aec0f..42d69d4 100644
    > --- a/drivers/bluetooth/hci_bcsp.c
    > +++ b/drivers/bluetooth/hci_bcsp.c
    > @@ -244,7 +244,7 @@ static struct sk_buff *bcsp_prepare_pkt(struct bcsp_struct *bcsp, u8 *data,
    > if (rel) {
    > hdr[0] |= 0x80 + bcsp->msgq_txseq;
    > BT_DBG("Sending packet with seqno %u", bcsp->msgq_txseq);
    > - bcsp->msgq_txseq = ++(bcsp->msgq_txseq)& 0x07;
    > + bcsp->msgq_txseq = (bcsp->msgq_txseq + 1)& 0x07;
    > }
    >
    > if (bcsp->use_crc)
    >
    >

    ahh.. so it's o.k. to add the value after bcsp->msgq_txseq instead of
    before. Anyways build clean over here..

    Thanks!

    Justin P. Mattock


    \
     
     \ /
      Last update: 2010-06-28 20:13    [W:0.050 / U:87.708 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site