Messages in this thread | | | Date | Sun, 27 Jun 2010 17:33:35 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/2] block: fix leaks associated with discard request payload |
| |
On Sun, Jun 27, 2010 at 09:32:07PM +0900, FUJITA Tomonori wrote: > On Sun, 27 Jun 2010 13:07:12 +0200 > Christoph Hellwig <hch@lst.de> wrote: > > > > How about this? > > > > As I tried to explain before this utterly confuses the I/O completion > > path. With the patch applied even a simple mkfs.xfs that issues discard > > just hangs. > > Wired. I just tried mkfs.xfs against scsi_debug with my block patches > (I saw one discard command). Seemed that it worked fine.
Doesn't work for me against either a real SSD or WRITE SAME support in qemu. But I think I didn't actually have your barrier patches applied, so I'll try again with a clean tree.
| |