Messages in this thread | | | Subject | Re: [RFC][PATCH 00/11] perf pmu interface -v2 | From | Peter Zijlstra <> | Date | Fri, 25 Jun 2010 13:16:29 +0200 |
| |
On Fri, 2010-06-25 at 12:11 +0100, Will Deacon wrote: > Hi Peter, > > On Thu, 2010-06-24 at 15:28 +0100, Peter Zijlstra wrote: > > These patches prepare the perf code for multiple pmus (no user > > interface yet, Lin Ming is working on that). These patches remove all > > weak functions and rework the struct pmu interface. > > > > The patches are boot tested on x86_64 and compile tested on: powerpc > > (!fsl, what config is that?), sparc and arm (sorry no SH compiler) > > > > I tried to test these for ARM, but I get compilation errors. Maybe you > forgot to enable perf in the ARM .config? Anyway, the compiler log is: > > CC arch/arm/kernel/perf_event.o > arch/arm/kernel/perf_event.c: In function 'validate_event': > arch/arm/kernel/perf_event.c:342: error: 'pmu' undeclared (first use in this function) > arch/arm/kernel/perf_event.c:342: error: (Each undeclared identifier is reported only once > arch/arm/kernel/perf_event.c:342: error: for each function it appears in.) > arch/arm/kernel/perf_event.c: In function 'armpmu_event_init': > arch/arm/kernel/perf_event.c:536: warning: return makes integer from pointer without a cast > arch/arm/kernel/perf_event.c: In function 'init_hw_perf_events': > arch/arm/kernel/perf_event.c:3037: error: expected ';' before 'return' > arch/arm/kernel/perf_event.c:3038: warning: no return statement in function returning non-void > make[1]: *** [arch/arm/kernel/perf_event.o] Error 1 > make: *** [arch/arm/kernel] Error 2 > > I think there's a missing semicolon, an ERR_PTR that should be a PTR_ERR > and an ordering issue with the pmu struct.
I seem to have lost a refresh before sending the emails, please check:
git://git.kernel.org/pub/scm/linux/kernel/git/peterz/linux-2.6-perf.git perf-pmu
I pushed out updated patches there.
| |