lkml.org 
[lkml]   [2010]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [RFC PATCH v2 1/5] irq: add tracepoint to softirq_raise
    From
    2010/6/25 KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>:
    > (cc to Lai)
    >
    >> This patch adds a tracepoint to raising of softirq.
    >> This is useful if you want to detect which hard interrupt raise softirq
    >> and lets you know a time between raising softirq and performing softirq.
    >> Combinating with other tracepoint, it lets us know a process of packets
    >> (See patch 0/5).
    >>
    >>           <idle>-0     [001] 241229.957184: softirq_raise: vec=3 [action=NET_RX]
    >>           <idle>-0     [000] 241229.993399: softirq_raise: vec=1 [action=TIMER]
    >>           <idle>-0     [000] 241229.993400: softirq_raise: vec=9 [action=RCU]
    >>
    >> This is a same patch Lai Jiangshan submitted.
    >> http://marc.info/?l=linux-kernel&m=126026122728732&w=2
    >
    > If so, you shouldn't remove author's info. please fix the description
    > as following.
    >
    > -------------------------------------------------------------------------
    > From: Lai Jiangshan <laijs@cn.fujitsu.com>
    >
    > This patch adds a tracepoint to raising of softirq.
    > This is useful if you want to detect which hard interrupt raise softirq
    > and lets you know a time between raising softirq and performing softirq.
    > Combinating with other tracepoint, it lets us know a process of packets
    > (See patch 0/5).
    >
    >          <idle>-0     [001] 241229.957184: softirq_raise: vec=3 [action=NET_RX]
    >          <idle>-0     [000] 241229.993399: softirq_raise: vec=1 [action=TIMER]
    >          <idle>-0     [000] 241229.993400: softirq_raise: vec=9 [action=RCU]
    >
    > This is a same below.
    > http://marc.info/?l=linux-kernel&m=126026122728732&w=2
    >
    > Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
    > Acked-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
    > Acked-by: Frederic Weisbecker <fweisbec@gmail.com>


    Right. And if you do some changes in the original patch, you can just
    change the description, or add a simple line before your Signed-off-by, that
    says:

    [ factorize softirq events with DECLARE_EVENT_CLASS ]

    Because indeed, as Steve said, the softirq_raise tracepoint should
    belong to the softirq event class as it perfectly matches it. This
    helps the kernel
    saving some space.

    Thanks.


    > Signed-off-by: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
    > --------------------------------------------------------------------------------
    >
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at  http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at  http://www.tux.org/lkml/
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-06-25 10:13    [W:0.029 / U:59.360 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site