lkml.org 
[lkml]   [2010]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] Staging: memrar: Moved memrar_allocator struct to memrar_allocator.c
From
Date
On 24.6.2010, at 12.16, Alan Cox wrote:

>> +size_t memrar_allocator_largest_free_area(struct memrar_allocator *allocator)
>> +{
>> + if (allocator == NULL)
>> + return 0;
>> + return allocator->largest_free_area;
>> +}
>
> static ?

The entire point of these two patches was to hide the memrar_allocator structure by moving it to memrar_allocator.c, forward declaring it in memrar_allocator.h and then providing accessor functions memrar_allocator_largest_free_area and memrar_allocator_capacity (this was the #2 issue for memrar_allocator.[ch] in the TODO file). By defining memrar_allocator_largest_free_area function as static (this is what you mean, right?) would make no sense.



\
 
 \ /
  Last update: 2010-06-24 11:31    [W:0.045 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site