lkml.org 
[lkml]   [2010]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/4] hwmon: Update sysfs-interface to include new attributes
On Thu, Jun 24, 2010 at 03:01:00PM -0700, Guenter Roeck wrote:
> Added _lcrit and _crit to voltage attributes.
> Added _lcrit to temperature attributes.
>
> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> ---
> Documentation/hwmon/sysfs-interface | 21 ++++++++++++++++++++-
> 1 files changed, 20 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface
> index d4e2917..7f60c0d 100644
> --- a/Documentation/hwmon/sysfs-interface
> +++ b/Documentation/hwmon/sysfs-interface
> @@ -107,10 +107,24 @@ in[0-*]_min Voltage min value.
> Unit: millivolt
> RW
>
> +in[0-*]_lcrit Voltage critical min value.
> + Unit: millivolt
> + RW
> + If voltage drops to or below this limit, the system may
> + take drastic action such as power down or reset. At the very
> + least, it should report a fault.
> +
> in[0-*]_max Voltage max value.
> Unit: millivolt
> RW
>
> +in[0-*]_crit Voltage critical max value.
> + Unit: millivolt
> + RW
> + If voltage reaches or exceeds this limit, the system may
> + take drastic action such as power down or reset. At the very
> + least, it should report a fault.
> +

The critical voltages API looks good to me.

I have a hwmon chip driver for the TI INA209 (which Jean NAK'd) that
could use these limits. I'll submit it again soon with changes to use
this new set of sysfs attributes.

It would be great to see a patch to libsensors and the sensors program
to allow it to display these limits too.

Thanks,
Ira

> in[0-*]_input Voltage input value.
> Unit: millivolt
> RO
> @@ -284,11 +298,16 @@ temp[1-*]_input Temperature input value.
> Unit: millidegree Celsius
> RO
>
> -temp[1-*]_crit Temperature critical value, typically greater than
> +temp[1-*]_crit Temperature critical max value, typically greater than
> corresponding temp_max values.
> Unit: millidegree Celsius
> RW
>
> +temp[1-*]_lcrit Temperature critical min value, typically lower than
> + corresponding temp_min values.
> + Unit: millidegree Celsius
> + RW
> +
> temp[1-*]_crit_hyst
> Temperature hysteresis value for critical limit.
> Unit: millidegree Celsius
> --
> 1.7.0.87.g0901d
>


\
 
 \ /
  Last update: 2010-06-25 01:35    [from the cache]
©2003-2011 Jasper Spaans