lkml.org 
[lkml]   [2010]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH for-2.6.35] virtio-pci: disable msi at startup
On Wed, Jun 23, 2010 at 05:21:37PM +0300, Avi Kivity wrote:
> On 06/23/2010 04:59 PM, Michael S. Tsirkin wrote:
>>
>>> Why doesn't a device reset result in msi being cleared?
>>>
>> This is not a standard function reset. This is virtio specific
>> command. So it only clears virtio registers.
>>
>
> I see. We should implement FLR in qemu.

We can do this. Or PM reset. however ...

> If we don't already do so, we
> should probably FLR anything that moves when a kexec kernel starts.

Probably only whatever we want to use. But whether this will make it
more, or less robust, is an open question.

>>> Shouldn't a reset be equivalent to power cycling?
>>>
>> If we did this, driver would need to restore registers
>> such as BAR etc.
>>
>
> We could save/restore the registers we care about.

It seems easier to clear registers we care about. It's also too late
now: changing behaviour will break old drivers.

> --
> error compiling committee.c: too many arguments to function


\
 
 \ /
  Last update: 2010-06-23 16:51    [W:0.049 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site