Messages in this thread | | | Subject | Re: [rfc] Describe events in a structured way via sysfs | From | Lin Ming <> | Date | Tue, 22 Jun 2010 15:22:39 +0800 |
| |
On Tue, 2010-06-22 at 14:59 +0800, Johannes Berg wrote: > On Tue, 2010-06-22 at 14:25 +0800, Lin Ming wrote: > > On Mon, 2010-06-21 at 17:34 +0800, Johannes Berg wrote: > > > On Mon, 2010-06-21 at 16:55 +0800, Lin Ming wrote: > > > > > > > 21. iwlwifi_io events > > > > /sys/devices/pci0000:00/0000:00:1c.1/0000:03:00.0/net/wlan0/events/iwlwifi_dev_ioread32/ > > > > ... > > > > /sys/devices/pci0000:00/0000:00:1c.1/0000:03:00.0/net/wlan0/events/iwlwifi_dev_ucode_event/ > > > > > > > > > That doesn't work, you could have multiple PCI devices in your system. > > > > Understood. This is just a "demo". > > > > Actually, I mean > > > > net/wlan0/events/ > > net/waln1/events/ > > .... > > net/walnN/events/ > > That's not appropriate either though since you may have multiple network > interfaces on the same hardware :)
Doesn't net/wlan0...wlanN mean multiple network interfaces on the same hardware?
If my understanding is wrong, would you show me an example in sysfs?
> > > > > 23. skb events > > > > /sys/class/net/events/kfree_skb/ > > > > /sys/class/net/events/skb_copy_datagram_iovec/ > > > > > > > 25. mac80211 events > > > > /sys/class/net/events/drv_start/ > > > > ... > > > > /sys/class/net/events/stop_queue > > > > > > It doesn't really seem right to mix all these. > > > > Well, agree, skb events are totally different with mac80211 events. > > Any idea? > > I suppose the most appropriate thing would > be /sys/class/ieee80211/phyN/events/... for almost all of them.
Good idea.
Thanks, Lin Ming
> > johannes >
| |