Messages in this thread | | | Date | Tue, 22 Jun 2010 15:39:13 -0700 | From | Greg KH <> | Subject | Re: [PATCH v2] Staging: dt3155: Cleanup memory mapped i/o access |
| |
On Mon, Jun 21, 2010 at 10:51:54AM -0500, H Hartley Sweeten wrote: > The macros ReadMReg and WriteMReg are really just private versions of > the kernel's readl and writel functions. Use the kernel's functions > instead. And since ioremap returns a (void __iomem *) not a (u8 *), > change all the uses of dt3155_lbase to reflect this. > > While here, make dt3155_lbase static since it is only used in the > dt3155_drv.c file. Also, remove the global variable dt3155_bbase > since it is not used anywhere in the code. > > Where is makes sense, create a local 'mmio' variable instead of using > dt3155_lbase[minor] to make the code more readable. > > This change also affects the {Read|Write}I2C functions so they are > also modified as needed. > > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> > Cc: Greg Kroah-Hartman <gregkh@suse.de> > Cc: Scott Smedley <ss@aao.gov.au> > > --- > > V2 - rebased to next-20100621
You are still doing something odd, this one doesn't apply either. Is your email client messing something up?
strange.
greg k-h
| |