lkml.org 
[lkml]   [2010]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code
    On Tue, Jun 22, 2010 at 02:37:52PM +0800, Barry Song wrote:
    [...]
    > >                jid = jedec_probe(spi);
    > >                if (!jid) {
    > > -                       dev_info(&spi->dev, "non-JEDEC variant of %s\n",
    > > -                                id->name);
    > > +                       return -ENODEV;
    > The patch looks good to me. Only problem is NULL is also returned by
    > spi_write_then_read() fail:
    [...]
    > Here much better for -EIO (return tmp)?

    Agreed. Though, this is not a regression, and I guess desires
    its own patch.

    Here are two patches, one for 2.6.35 (minimal changes to fix
    the JEDEC problem), another for 2.6.36.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-06-22 18:59    [from the cache]
    ©2003-2011 Jasper Spaans