lkml.org 
[lkml]   [2010]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/9] oom: oom_kill_process() need to check p is unkillable
On Mon, 21 Jun 2010, KOSAKI Motohiro wrote:

> > > When oom_kill_allocating_task is enabled, an argument task of
> > > oom_kill_process is not selected by select_bad_process(), It's
> > > just out_of_memory() caller task. It mean the task can be
> > > unkillable. check it first.
> > >
> >
> > This should be unnecessary if oom_kill_process() appropriately returns
> > non-zero when it cannot kill a task. What problem are you addressing with
> > this fix?
>
> oom_kill_process() only check its children are unkillable, not its own.

No, oom_kill_process() returns the value of oom_kill_task(victim) which is
non-zero for !victim->mm in mmotm-2010-06-11-16-40 (and 2.6.34 although
victim == p in that case).


\
 
 \ /
  Last update: 2010-06-21 22:07    [from the cache]
©2003-2011 Jasper Spaans