lkml.org 
[lkml]   [2010]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    Subject[PATCH 0/2] pid_ns_release_proc() fixes
    On 06/20, Oleg Nesterov wrote:
    >
    > On 06/20, Eric W. Biederman wrote:
    > >
    > > Oleg Nesterov <oleg@redhat.com> writes:
    > >
    > > > I am going to simplify, test, and send the fix which moves mntput()
    > > > into free_pid_ns() paths.
    > >
    > > free_pid_ns is comparatively late, to release the kern_mount.
    >
    > Why?
    >
    > Once again, it is very possible I am wrong. I forgot this code if ever
    > knew. But could you please explain?

    So. Please the the patches. On top of

    [PATCH 1/4] procfs: proc_get_sb: consolidate/cleanup root_inode->pid logic
    [PATCH 2/4] procfs: kill the global proc_mnt variable
    [PATCH 3/4] procfs: move pid_ns_prepare_proc() from copy_process() to create_pid_namespace()

    Still untested, sorry. There was no electricity in office this weekend,
    and I can hardly work from home ;) I am sending this fix for review.

    And let me repeat, I do not think this approach is the best (even _if_
    this change is correct), just my attempt to fix the bugs.

    What do you think?

    Oleg.



    \
     
     \ /
      Last update: 2010-06-20 20:09    [W:0.023 / U:30.540 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site