lkml.org 
[lkml]   [2010]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/6 v2]cifs Fix warnings variables set but not used

>> /* since paths are not looked up by component - the parent
>> directories are presumed to be good here */
>> renew_parental_timestamps(direntry);
>> diff --git a/fs/cifs/file.c b/fs/cifs/file.c
>> index 75541af..73e540b 100644
>> --- a/fs/cifs/file.c
>> +++ b/fs/cifs/file.c
>> @@ -1312,7 +1312,7 @@ static int cifs_partialpagewrite(struct page *page, unsigned from, unsigned to)
>> int rc = -EFAULT;
>> int bytes_written = 0;
>> struct cifs_sb_info *cifs_sb;
>> - struct cifsTconInfo *pTcon;
>> + struct cifsTconInfo *pTcon __attribute__((unused));
>
> This variable can just be removed (along with the spot where it gets
> set later).
>
>> struct inode *inode;
>> struct cifsFileInfo *open_file;
>>
>
>

one thing I want to make sure of before sending this out, is with file.c
if I remove *pTcon another warning shows up:

CC [M] fs/cifs/file.o
fs/cifs/file.c: In function 'cifs_partialpagewrite':
fs/cifs/file.c:1314:23: warning: variable 'cifs_sb' set but not used

with the original patch I had removed this as well, should I do this or
is this not a good idea?

Justin P. Mattock


\
 
 \ /
  Last update: 2010-06-21 00:37    [from the cache]
©2003-2011 Jasper Spaans