lkml.org 
[lkml]   [2010]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/6] Unshare support for the pid namespace.
    On 06/20, Eric W. Biederman wrote:
    >
    > Oleg Nesterov <oleg@redhat.com> writes:
    >
    > > And. I do not think these series can fix the discussed problems. ns->dead
    > > definitely can't, no?
    >
    > I'm am fairly confident that we have the signal sending races fixed so
    > we can reasonably expect having sent SIGKILL to all processes in a pid
    > namespace

    Sorry, didn't notice this part...

    Which races? I am talking about the current problems with pid_ns_release_proc(),
    we have at least 3 bugs, from the 2/2 changelog:

    - Nobody does mntput() if copy_process() fails after
    pid_ns_prepare_proc().

    - proc_flush_task() checks upid->nr == 1 to verify we are init,
    this is wrong if a multi-threaded init does exec.

    - As Louis pointed out, this namespace can have the detached
    EXIT_DEAD tasks which can use ns->proc_mnt after this mntput().

    Oleg.



    \
     
     \ /
      Last update: 2010-06-21 00:05    [W:4.205 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site