Messages in this thread | | | Date | Wed, 2 Jun 2010 17:20:38 +0900 | From | Paul Mundt <> | Subject | Re: [PATCH] binfmt_elf_fdpic: Fix clear_user() error handling |
| |
On Tue, Jun 01, 2010 at 02:10:47PM +0100, David Howells wrote: > From: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp> > > clear_user() returns the number of bytes that could not be copied rather than > an error code. So we should return -EFAULT rather than directly returning the > results. > > Without this patch, positive values may be returned to elf_fdpic_map_file() > and the following error handlings do not function as expected. > > 1. > ret = elf_fdpic_map_file_constdisp_on_uclinux(params, file, mm); > if (ret < 0) > return ret; > 2. > ret = elf_fdpic_map_file_by_direct_mmap(params, file, mm); > if (ret < 0) > return ret; > > Signed-off-by: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp> > Signed-off-by: David Howells <dhowells@redhat.com> > Acked-by: Mike Frysinger <vapier@gentoo.org> > CC: Alexander Viro <viro@zeniv.linux.org.uk> > CC: Andrew Morton <akpm@linux-foundation.org> > CC: Daisuke HATAYAMA <d.hatayama@jp.fujitsu.com> > CC: Paul Mundt <lethal@linux-sh.org>
Acked-by: Paul Mundt <lethal@linux-sh.org>
| |