lkml.org 
[lkml]   [2010]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] module: fix bne2 "gave up waiting for init of module libcrc32c"


On Wed, 2 Jun 2010, Rusty Russell wrote:
>
> > I would like to note that your original "fix things by dropping the lock"
> > patch that I hated so much had this exact bug too. Making this a good
> > example of _why_ it's basically always wrong to drop locks in the middle -
> > even if you claimed you knew and understood the locking.
>
> And I would like to note that it didn't :) It grabbed references only on
> completed modules.

Right you are, I misread the patch. You re-did the whole module lookup,
something that the original code didn't do. And yes, that should be safe.

Linus


\
 
 \ /
  Last update: 2010-06-02 06:39    [W:1.057 / U:1.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site