Messages in this thread | | | Date | Tue, 1 Jun 2010 21:32:19 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH 2/2] module: fix bne2 "gave up waiting for init of module libcrc32c" |
| |
On Wed, 2 Jun 2010, Rusty Russell wrote: > > > I would like to note that your original "fix things by dropping the lock" > > patch that I hated so much had this exact bug too. Making this a good > > example of _why_ it's basically always wrong to drop locks in the middle - > > even if you claimed you knew and understood the locking. > > And I would like to note that it didn't :) It grabbed references only on > completed modules.
Right you are, I misread the patch. You re-did the whole module lookup, something that the original code didn't do. And yes, that should be safe.
Linus
| |