Messages in this thread | | | Date | Thu, 3 Jun 2010 09:46:24 +0900 | Subject | Re: [PATCH 5/5] oom: dump_tasks() use find_lock_task_mm() too | From | Minchan Kim <> |
| |
On Thu, Jun 3, 2010 at 9:41 AM, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote: >> On Thu, Jun 3, 2010 at 9:06 AM, KOSAKI Motohiro >> <kosaki.motohiro@jp.fujitsu.com> wrote: >> >> > - mm = p->mm; >> >> > - if (!mm) { >> >> > - /* >> >> > - * total_vm and rss sizes do not exist for tasks with no >> >> > - * mm so there's no need to report them; they can't be >> >> > - * oom killed anyway. >> >> > - */ >> >> >> >> Please, do not remove the comment for mm newbies unless you think it's useless. >> > >> > How is this? >> > >> > task = find_lock_task_mm(p); >> > if (!task) >> > /* >> > * Probably oom vs task-exiting race was happen and ->mm >> > * have been detached. thus there's no need to report them; >> > * they can't be oom killed anyway. >> > */ >> > continue; >> > >> >> Looks good to adding story about racing. but my point was "total_vm >> and rss sizes do not exist for tasks with no mm". But I don't want to >> bother you due to trivial. >> It depends on you. :) > > > old ->mm check have two intention. > > a) the task is kernel thread? > b) the task have alredy detached ->mm > but a) is not strictly correct check because we should think use_mm(). > therefore we appended PF_KTHREAD check. then, here find_lock_task_mm() > focus exiting race, I think. >
No objection.
-- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |