Messages in this thread | | | Date | Wed, 02 Jun 2010 15:25:11 +0300 | From | Avi Kivity <> | Subject | Re: [PATCH] VFIO driver: Non-privileged user level PCI drivers |
| |
On 06/02/2010 03:19 PM, Joerg Roedel wrote: > >> Yes. so you do: >> iommu = open >> ioctl(dev1, BIND, iommu) >> ioctl(dev2, BIND, iommu) >> ioctl(dev3, BIND, iommu) >> ioctl(dev4, BIND, iommu) >> >> No need to add a SHARE ioctl. >> > In my proposal this looks like: > > > dev1 = open(); > ioctl(dev2, SHARE, dev1); > ioctl(dev3, SHARE, dev1); > ioctl(dev4, SHARE, dev1); > > So we actually save an ioctl. >
The problem with this is that it is assymetric, dev1 is treated differently from dev[234]. It's an unintuitive API.
-- error compiling committee.c: too many arguments to function
| |