Messages in this thread | | | Date | Wed, 2 Jun 2010 10:47:33 +0100 | From | Mark Brown <> | Subject | Re: [Uclinux-dist-devel] [PATCH v2] regulator: new drivers for AD5398 and AD5821 |
| |
On Wed, Jun 02, 2010 at 05:02:58AM -0400, Mike Frysinger wrote:
> > + dev_dbg(&client->dev, "%s regulator driver loaded\n", id->name);
> does the regulator core take care of displaying a notice ? if not, > i'd make this dev_info(). also, this should be "registered", not > "loaded".
A message will be displayed if the device actually has any constraints (and is therefore in use) so if it makes any difference to the system there will be some chat.
> > +MODULE_DESCRIPTION("AD5398 and AD5821 current regulator driver"); > > +MODULE_AUTHOR("Sonic Zhang"); > > +MODULE_LICENSE("GPL");
> should there be a MODULE_ALIAS() ?
Possibly, though it's unlikely that actual systems will ever build a regulator they're using as a module.
| |